<html>
<head><meta charset="utf-8"><title>Make lang-items private compiler-team#301 · t-compiler/major changes · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/index.html">t-compiler/major changes</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html">Make lang-items private compiler-team#301</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="199764211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199764211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199764211">(Jun 04 2020 at 15:29)</a>:</h4>
<p>A new proposal has been announced <a href="https://github.com/rust-lang/compiler-team/issues/301">#301</a>. It will be brought up at the next meeting.</p>



<a name="199764458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199764458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199764458">(Jun 04 2020 at 15:31)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="492">@T-compiler</span>: Proposal <a href="https://github.com/rust-lang/compiler-team/issues/301#issuecomment-638926775">#301</a> has been seconded, and will be approved in 10 days if no objections are raised.</p>



<a name="199764519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199764519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199764519">(Jun 04 2020 at 15:31)</a>:</h4>
<p>I like the idea of also making it more ergonomic to compare against a particular <code>def_id</code></p>



<a name="199764993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199764993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199764993">(Jun 04 2020 at 15:34)</a>:</h4>
<p><span class="user-mention" data-user-id="225949">@Nathan Corbyn</span> one thing I would add -- I think you should also document the various kinds of "lang items" in rustc-dev-guide :)</p>



<a name="199765051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199765051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199765051">(Jun 04 2020 at 15:34)</a>:</h4>
<p>(I've seen now we have things like "documentation items" too..? I forget.)</p>



<a name="199765068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199765068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199765068">(Jun 04 2020 at 15:34)</a>:</h4>
<p>but basically saying what a lang item is, how it's used, etc</p>



<a name="199765627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199765627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Corbyn <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199765627">(Jun 04 2020 at 15:38)</a>:</h4>
<p>Ah! I forgot to mention that - definitely agree</p>



<a name="199765684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199765684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Corbyn <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199765684">(Jun 04 2020 at 15:38)</a>:</h4>
<p>Should I tack that on the end of the MCP?</p>



<a name="199773008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199773008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199773008">(Jun 04 2020 at 16:26)</a>:</h4>
<p>we have diagnostic items</p>



<a name="199773034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199773034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199773034">(Jun 04 2020 at 16:26)</a>:</h4>
<p>used by rustc and clippy lints so we don't have to refer to things by path</p>



<a name="199775116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199775116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199775116">(Jun 04 2020 at 16:43)</a>:</h4>
<p>yeah. it'd be good to document those. I'm not really clear on what the difference is =) presumably more just a difference of intent...</p>



<a name="199775175"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/Make%20lang-items%20private%20compiler-team%23301/near/199775175" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/Make.20lang-items.20private.20compiler-team.23301.html#199775175">(Jun 04 2020 at 16:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="225949">Nathan Corbyn</span> <a href="#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/Make.20lang-items.20private.20compiler-team.23301/near/199765684">said</a>:</p>
<blockquote>
<p>Should I tack that on the end of the MCP?</p>
</blockquote>
<p>doesn't hurt but also not really necessary in my view :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>